-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU][ARM64] Enable FakeQuantize tokenization and decomposition #28700
base: master
Are you sure you want to change the base?
Conversation
Hi @a-sidorova, please review this PR whenever you can. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments to improve code readability in test files 😊
Good job! 👍🏼
...el_cpu/tests/functional/shared_tests_instances/snippets/fake_quantize_decomposition_test.cpp
Outdated
Show resolved
Hide resolved
...el_cpu/tests/functional/shared_tests_instances/snippets/fake_quantize_decomposition_test.cpp
Outdated
Show resolved
Hide resolved
build_jenkins |
...el_cpu/tests/functional/shared_tests_instances/snippets/fake_quantize_decomposition_test.cpp
Outdated
Show resolved
Hide resolved
build_jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srinjoydutta03 thank you for the one more contribution from you! Really good job! 👍🏼
Let us know please if you're interested to take one more GFI for ARM/Snippets 😊
Currently, all of them are assigned but some of them have the same assignee - I think we can free them if needed.
Thanks @a-sidorova, I would love to take another issue up :). |
Details:
src/plugins/intel_cpu/tests/functional/shared_tests_instances/skip_tests_config.cpp
is_supported_op
intransformation_pipeline.cpp
FakeQuantizeDecompositionTest::SetUp()
, replaced MaxPool ops (makePrerequisitesOriginal()
) with empty vector due to outdated limitations in Snippets, to support the operation in AArch64 platforms.reorder
ops are missed in AArch64 platforms and disabledlegacyFuse
tests for non-x64 platforms.Tests
Passed local testsTickets: