Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU][ARM64] Enable FakeQuantize tokenization and decomposition #28700

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

srinjoydutta03
Copy link
Contributor

Details:

  • Enabled tests for FakeQuantizeDecomposition in src/plugins/intel_cpu/tests/functional/shared_tests_instances/skip_tests_config.cpp
  • Enabled FakeQuantize op tokenization by adding it in is_supported_op in transformation_pipeline.cpp
  • Updated FakeQuantizeDecompositionTest::SetUp(), replaced MaxPool ops (makePrerequisitesOriginal()) with empty vector due to outdated limitations in Snippets, to support the operation in AArch64 platforms.
  • Adjusted expected node counts in tests since reorder ops are missed in AArch64 platforms and disabled legacyFuse tests for non-x64 platforms.

Tests

Screenshot 2025-01-27 at 4 53 59 PM Passed local tests

Tickets:

@srinjoydutta03 srinjoydutta03 requested review from a team as code owners January 27, 2025 16:39
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: CPU OpenVINO CPU plugin labels Jan 27, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jan 27, 2025
@srinjoydutta03
Copy link
Contributor Author

Hi @a-sidorova, please review this PR whenever you can. Thank you

Copy link
Contributor

@a-sidorova a-sidorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments to improve code readability in test files 😊

Good job! 👍🏼

@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova a-sidorova added this to the 2025.1 milestone Jan 28, 2025
Copy link
Contributor

@a-sidorova a-sidorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinjoydutta03 thank you for the one more contribution from you! Really good job! 👍🏼

Let us know please if you're interested to take one more GFI for ARM/Snippets 😊
Currently, all of them are assigned but some of them have the same assignee - I think we can free them if needed.

@srinjoydutta03
Copy link
Contributor Author

Thanks @a-sidorova, I would love to take another issue up :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [Snippets] [ARM]: Enable FakeQuantize tokenization
4 participants