[CPU][DEBUG_CAPS] Bring back an execution of all nodes for debug caps #28597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxnick Could you please a look |
The logic was reverted due to the issues with making all the nodes executable in some scenarious. The problem is that without this functionality debug capabilities became less usable. So bring back the logic and try to cover problematic scenarios, i.e. static nodes with empty shapes, which never should be executed even with debug caps.
EgorDuplensky
force-pushed
the
revert_debug_caps_executable
branch
from
b101670 to
80c25fc
Compare
maxnick
requested changes
Jan 22, 2025
maxnick
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was reverted due to the issues with making all the nodes
executable in some scenarious.
The problem is that without this functionality debug capabilities became
less usable.
So bring back the logic and try to cover problematic scenarios,
i.e. static nodes with empty shapes, which should never be executed
even with debug caps.