Fixed C++ RTTI for Core base classes #28555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
itikhono
approved these changes
Jan 20, 2025
t-jankowski
approved these changes
Jan 20, 2025
ilya-lavrenov
force-pushed
the
basepass-rtti
branch
from
15b59ad to
3baf5a5
Compare
ilya-lavrenov
changed the title
|
@itikhono @t-jankowski added more classes to a list of fixed one. Please, review once again |
itikhono
approved these changes
Jan 20, 2025
ilya-lavrenov
force-pushed
the
basepass-rtti
branch
from
3baf5a5 to
0936a33
Compare
github-actions
bot
added
the
category: LP transformations
ilya-lavrenov
force-pushed
the
basepass-rtti
branch
from
0936a33 to
28d7734
Compare
t-jankowski
approved these changes
Jan 20, 2025
praasz
reviewed
Jan 20, 2025
src/common/low_precision_transformations/include/low_precision/cleanup_transformation.hpp
Outdated
Show resolved
Hide resolved
ilya-lavrenov
force-pushed
the
basepass-rtti
branch
2 times, most recently
from
08f5636 to
50b7bcd
Compare
praasz
approved these changes
Jan 21, 2025
ilya-lavrenov
force-pushed
the
basepass-rtti
branch
from
50b7bcd to
ac721b6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ilya-lavrenov
added a commit
to ilya-lavrenov/openvino
that referenced
this pull request
Jan 22, 2025
Android support:
<img width="200" alt="{ABD03686-78FD-4F33-A2E8-C3BE1C030D5C}"
src="https://github.com/user-attachments/assets/55bb0600-4f14-448c-b4be-e1e97e354859"
/>
in header files threated as an inline definition, which typically
results in a "weak" symbol
"weak" symbols are not exported from dll/so libs.
To make these symbols "strong", we moved the definitions to ".cpp"
files.
This was referenced Jan 22, 2025
ilya-lavrenov
added a commit
that referenced
this pull request
Jan 23, 2025
### Details: - Regression after #28555
ilya-lavrenov
added a commit
to ilya-lavrenov/openvino
that referenced
this pull request
Jan 23, 2025
Android support:
<img width="200" alt="{ABD03686-78FD-4F33-A2E8-C3BE1C030D5C}"
src="https://github.com/user-attachments/assets/55bb0600-4f14-448c-b4be-e1e97e354859"
/>
in header files threated as an inline definition, which typically
results in a "weak" symbol
"weak" symbols are not exported from dll/so libs.
To make these symbols "strong", we moved the definitions to ".cpp"
files.
ilya-lavrenov
added a commit
to ilya-lavrenov/openvino
that referenced
this pull request
Jan 23, 2025
### Details: - Regression after openvinotoolkit#28555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Android support:
in header files threated as an inline definition, which typically results in a "weak" symbol
"weak" symbols are not exported from dll/so libs.
To make these symbols "strong", we moved the definitions to ".cpp" files.