Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE] Added aten::logaddexp #28539

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[PT FE] Added aten::logaddexp #28539

wants to merge 6 commits into from
+194 −0

Conversation

itsbharatj
Copy link
Contributor

Details:

Added aten::logcumsumexp

Tickets:

@itsbharatj itsbharatj requested a review from a team as a code owner January 19, 2025 18:07
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 19, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jan 19, 2025
@itsbharatj itsbharatj changed the title Logaddexp [PT FE] Added aten::logaddexp Jan 19, 2025
@itsbharatj itsbharatj mentioned this pull request Jan 19, 2025
Open
@rkazants rkazants linked an issue Jan 19, 2025 that may be closed by this pull request
[Good First Issue]: Support aten::logaddexp #28529
Open
@rkazants
Copy link
Member

build_jenkins

@itsbharatj itsbharatj requested a review from rkazants January 19, 2025 19:34
@itsbharatj
Copy link
Contributor Author

itsbharatj commented Jan 19, 2025 •
edited
Loading

Can you let me know for any changes required/approve the CI request @rkazants

Thanks!

mvafin
mvafin requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests fail for FP64 dtype, because you align the output of the operation to input1 which you previously converted to FP32. With my suggestions the tests should pass.

src/frontends/pytorch/src/op/logaddexp.cpp Show resolved Hide resolved
src/frontends/pytorch/src/op/logaddexp.cpp Show resolved Hide resolved
tests/layer_tests/pytorch_tests/test_logaddexp.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants left review comments

@mvafin mvafin mvafin requested changes

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz mmikolajcz is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support aten::logaddexp
4 participants
@itsbharatj @rkazants @mvafin @sys-openvino-ci