Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snippets] Implemented SetDynamicWAToOuterMostLoop pass #28505

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

a-sidorova
Copy link
Contributor

@a-sidorova a-sidorova commented Jan 17, 2025

Details:

  • Dynamic MHA Subgraphs may have only dynamic batch. Then the pass MHAParallelWAOptimizer cannot be applied to this subgraph to increase parallel work amount since outermost Loop By M in MHA has static work amount. Then Subgraph may be inefficiently executed. This PR implemented the pass SetDynamicWAToOuterMostLoop which sets dynamic work amount to outmost Loop in dynamic MHA to make applicable MHAParallelWAOptimizer in runtime.

Tickets:

  • 160647

Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mg-intel mg-intel added this pull request to the merge queue Jan 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2025
…ss (#28506)

### Details:
- *Dynamic MHA Subgraphs may have only dynamic batch. Then the pass
`MHAParallelWAOptimizer` cannot be applied to this subgraph to increase
parallel work amount since outermost Loop By M in MHA has static work
amount. Then Subgraph may be inefficiently executed. This PR implemented
the pass `SetDynamicWAToOuterMostLoop ` which sets dynamic work amount
to outmost Loop in dynamic MHA to make applicable
`MHAParallelWAOptimizer` in runtime.*
 - *Original PR: #28505

### Tickets:
 - *160647*
Merged via the queue into openvinotoolkit:master with commit 58766e7 Jan 17, 2025
343 of 345 checks passed
MirceaDan99 pushed a commit to MirceaDan99/openvino that referenced this pull request Jan 22, 2025
…kit#28505)

### Details:
- *Dynamic MHA Subgraphs may have only dynamic batch. Then the pass
`MHAParallelWAOptimizer` cannot be applied to this subgraph to increase
parallel work amount since outermost Loop By M in MHA has static work
amount. Then Subgraph may be inefficiently executed. This PR implemented
the pass `SetDynamicWAToOuterMostLoop ` which sets dynamic work amount
to outmost Loop in dynamic MHA to make applicable
`MHAParallelWAOptimizer` in runtime.*

### Tickets:
 - *160647*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants