Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 2-step conversion from fp32 to fp8 #28501

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Implement 2-step conversion from fp32 to fp8 #28501

merged 3 commits into from
Feb 18, 2025

Conversation

xuchen-intel
Copy link
Contributor

Details:

  • Implement reference conversion from fp16 to f8e4m3, and apply 2-step conversion, i.e., apply fp32->fp16, then fp16->fp8 for conversions from fp32 to fp8.

Tickets:

@xuchen-intel xuchen-intel added this to the 2025.1 milestone Jan 17, 2025
@xuchen-intel xuchen-intel requested review from a team as code owners January 17, 2025 03:20
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin labels Jan 17, 2025
@xuchen-intel xuchen-intel force-pushed the fix/two_step_downconversion branch 4 times, most recently from c5864f1 to b72fd64 Compare January 17, 2025 05:25
@xuchen-intel xuchen-intel changed the title [Draft] Implement 2-step conversion from fp32 to fp8 Implement 2-step conversion from fp32 to fp8 Jan 27, 2025
@xuchen-intel
Copy link
Contributor Author

@dmitry-gorokhov Hi Dmitry! Could you please take a look?

@praasz praasz self-assigned this Jan 27, 2025
praasz
praasz requested changes Jan 27, 2025
View reviewed changes
@xuchen-intel xuchen-intel requested a review from praasz February 10, 2025 03:02
praasz
praasz reviewed Feb 10, 2025
View reviewed changes
@xuchen-intel xuchen-intel force-pushed the fix/two_step_downconversion branch 2 times, most recently from 7d61fa0 to 3d8c62f Compare February 11, 2025 03:23
@xuchen-intel xuchen-intel requested a review from praasz February 11, 2025 03:23
@xuchen-intel xuchen-intel force-pushed the fix/two_step_downconversion branch from 3d8c62f to 7808775 Compare February 12, 2025 05:23
@xuchen-intel xuchen-intel force-pushed the fix/two_step_downconversion branch from 7808775 to 4c740c8 Compare February 14, 2025 03:40
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 18, 2025
Merged via the queue into openvinotoolkit:master with commit 3efb13a Feb 18, 2025
185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@praasz praasz praasz approved these changes

Assignees

@praasz praasz

Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xuchen-intel @dmitry-gorokhov @praasz