Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPU] Re-create zero tensor for internal usage if it was shared with user #28438

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

pereanub
Copy link
Contributor

@pereanub pereanub commented Jan 14, 2025

Details:

  • Hotfix GenAI
  • Re-create the internal level zero tensor for internal usage if this has already been shared with the user. And do not re-use the shared memory

Tickets:

@pereanub pereanub requested review from a team as code owners January 14, 2025 13:48
@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Jan 14, 2025
@pereanub pereanub requested review from dmatveev and esmirno January 14, 2025 14:04
levelZeroTensors = tensor;
} else {
OV_ITT_TASK_NEXT(ZERO_SET_TENSOR, "check_data_allocation");
if (memory_was_allocated_in_the_same_l0_context(_initStructs->getContext(), tensor->data())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least i see that debug print on second inferrequest create : where previously it missed :

image

@pereanub pereanub added this to the 2025.0 milestone Jan 14, 2025
@pereanub pereanub changed the title [NPU] Changing set_tensor_data flow [NPU] Re-create zero tensor for internal usage if it was shared with user Jan 15, 2025
@moslex moslex added the priority: high High piority label Jan 15, 2025
@pereanub pereanub added this pull request to the merge queue Jan 15, 2025
@pereanub pereanub removed this pull request from the merge queue due to a manual request Jan 15, 2025
Signed-off-by: Bogdan Pereanu <[email protected]>
Signed-off-by: Bogdan Pereanu <[email protected]>
Signed-off-by: Bogdan Pereanu <[email protected]>
Signed-off-by: Bogdan Pereanu <[email protected]>
@pereanub pereanub force-pushed the fix_set_tensor_data branch from 655ac3c to 4290291 Compare January 15, 2025 11:48
@pereanub pereanub added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@pereanub pereanub added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@pereanub pereanub added this pull request to the merge queue Jan 15, 2025
Merged via the queue into openvinotoolkit:master with commit 2f5af17 Jan 15, 2025
157 checks passed
@pereanub pereanub deleted the fix_set_tensor_data branch January 15, 2025 17:10
MirceaDan99 pushed a commit to MirceaDan99/openvino that referenced this pull request Jan 22, 2025
…user (openvinotoolkit#28438)

### Details:
 - *Hotfix GenAI*
- *Re-create the internal level zero tensor for internal usage if this
has already been shared with the user. And do not re-use the shared
memory*

### Tickets:
 - *CVS-160546*

---------

Signed-off-by: Bogdan Pereanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NPU OpenVINO NPU plugin Code Freeze priority: high High piority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants