Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Enchant Edge "to string" logic #27563

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[CPU] Enchant Edge "to string" logic #27563

merged 1 commit into from
Nov 25, 2024

Conversation

EgorDuplensky
Copy link
Contributor

by replacing "name()" with ostream operator.
Also include "status" to the printed information.

@EgorDuplensky EgorDuplensky requested review from a team as code owners November 14, 2024 16:38
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Nov 14, 2024
@EgorDuplensky
Copy link
Contributor Author

@dmitry-gorokhov Could you plese take a look

dmitry-gorokhov
dmitry-gorokhov approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorDuplensky I am ok with the changes. Just fro my understanding: what is rationale behind it?

@dmitry-gorokhov dmitry-gorokhov added this to the 2025.0 milestone Nov 18, 2024
@EgorDuplensky
Copy link
Contributor Author

@EgorDuplensky I am ok with the changes. Just fro my understanding: what is rationale behind it?

The base idea is just to include Status into the edge toString logic.
Rest of the changes are just consequences of that idea. For example, we cannot really include Status into edge "name()" method, because this method is actually being used as a key in weights cache storage. So, to avoid any confusion, I have renamed name() method into the hash() and implemented operator overloading as it is usually done

@EgorDuplensky
[CPU] Enchant Edge "to string" logic
1b7d811 
by replacing "name()" with ostream operator.
Also include "status" to the printed information.
@EgorDuplensky EgorDuplensky force-pushed the include_edge_status_to_its_name branch from 37c3556 to 1b7d811 Compare November 19, 2024 13:15
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Nov 25, 2024
Merged via the queue into openvinotoolkit:master with commit 0942797 Nov 25, 2024
165 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the include_edge_status_to_its_name branch November 25, 2024 13:44
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
@EgorDuplensky @NishantPrabhuFujitsu
[CPU] Enchant Edge "to string" logic (openvinotoolkit#27563)
b83fc3a 
by replacing "name()" with ostream operator.
Also include "status" to the printed information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorDuplensky @dmitry-gorokhov