Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OV JS] npm run lint on .js files #26543

Merged
merged 10 commits into from
Sep 20, 2024

Conversation

almilosz
Copy link
Contributor

Details:

  • include *.js files
  • Fix codestyle errors about max-len, snake-case etc.

Tickets:

  • ticket-id

@github-actions github-actions bot added the category: JS API OpenVino JS API Bindings label Sep 11, 2024
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add at the top of src\bindings\js\node\tests\e2e\electron-app.test.js:
/* global describe, it, before, after */

And content of src\bindings\js\node\.eslintrc.js should be:

module.exports = {
  extends: ['../.eslintrc.js'],
  env: {
    node: true,
  },
  parser: '@typescript-eslint/parser',
  plugins: ['@typescript-eslint'],
};

After this PR merge I propose consider about this:
https://eslint.org/docs/latest/use/migrate-to-9.0.0

@almilosz almilosz marked this pull request as ready for review September 16, 2024 13:18
@almilosz almilosz requested a review from a team as a code owner September 16, 2024 13:18
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@vishniakov-nikolai vishniakov-nikolai added this to the 2024.5 milestone Sep 19, 2024
@almilosz almilosz added this pull request to the merge queue Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
### Details:
 - include *.js files
 - Fix codestyle errors about max-len, snake-case etc.

### Tickets:
 - *ticket-id*
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@mlukasze mlukasze added this pull request to the merge queue Sep 20, 2024
Merged via the queue into openvinotoolkit:master with commit b4af3d5 Sep 20, 2024
151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: JS API OpenVino JS API Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants