-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index fill pytorch #26488
Index fill pytorch #26488
Conversation
Co-authored-by: Maxim Vafin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the conversion function in the list of operators here: https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op_table.cpp
ok will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check
hi,how can i address these issues?? |
Yes, please fix code style issues: https://github.com/openvinotoolkit/openvino/actions/runs/10785003751/job/29925825017 |
pls verify @mvafin |
hi,i fixed the issues but still the same error is popping up??? |
@mvafin anything i can do to fix this error?? |
?? |
@mlukasze what seems to be the error i cant pinpoint it pls help |
I'm looking on it, will back to you if it is something you could fix. |
thanks for your response |
hi @mlukasze when will this be merged?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code can't be compiled
auto index = context.get_input(2); | ||
auto value = context.get_input(3); | ||
|
||
auto const_1_vec = v0::Constant::create(element::i32, Shape{1}, {value}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value
is Node, you are trying to create a constant from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will fix
@mvafin hi pls check now |
@muhd360 Tests fail with:
|
ok working on it |
@mvafin im getting this error now and i cant seem to figure out the solution |
@muhd360 This error is printed if you do not have implementation of the conversion for this operation. Do you have a release version of openvino in your enviroment? |
but i did add the converter right?yes i have openvino installed on the system |
You need to build openvino with your changes, do not use release version. |
how can i do this? |
thanks a ton |
hi @mvafin pls assign this issue to someone else im struggling with the build from very long.Sorry to waste your time |
Details:
added Support for aten::index_fill_ for pytorch models
Tickets:
23326