Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index fill pytorch #26488

Closed
wants to merge 18 commits into from
Closed

Conversation

muhd360
Copy link

@muhd360 muhd360 commented Sep 9, 2024

Details:

added Support for aten::index_fill_ for pytorch models

  • ...

Tickets:

23326

@muhd360 muhd360 requested a review from a team as a code owner September 9, 2024 09:52
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Sep 9, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Sep 9, 2024
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the conversion function in the list of operators here: https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op_table.cpp

@muhd360
Copy link
Author

muhd360 commented Sep 9, 2024

You need to add the conversion function in the list of operators here: https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op_table.cpp

ok will do

Copy link
Author

@muhd360 muhd360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check

@muhd360
Copy link
Author

muhd360 commented Sep 11, 2024

hi,how can i address these issues??

@mvafin
Copy link
Contributor

mvafin commented Sep 11, 2024

hi,how can i address these issues??

Yes, please fix code style issues: https://github.com/openvinotoolkit/openvino/actions/runs/10785003751/job/29925825017
And build issues

@muhd360
Copy link
Author

muhd360 commented Sep 11, 2024

pls verify @mvafin

@muhd360
Copy link
Author

muhd360 commented Sep 12, 2024

hi,i fixed the issues but still the same error is popping up???

@muhd360
Copy link
Author

muhd360 commented Sep 12, 2024

@mvafin anything i can do to fix this error??

@muhd360
Copy link
Author

muhd360 commented Sep 15, 2024

@mvafin anything i can do to fix this error??

??

@muhd360
Copy link
Author

muhd360 commented Sep 18, 2024

@mlukasze what seems to be the error i cant pinpoint it pls help

@mlukasze
Copy link
Contributor

I'm looking on it, will back to you if it is something you could fix.

@muhd360
Copy link
Author

muhd360 commented Sep 18, 2024

thanks for your response

@muhd360
Copy link
Author

muhd360 commented Sep 20, 2024

hi @mlukasze when will this be merged??

Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code can't be compiled

auto index = context.get_input(2);
auto value = context.get_input(3);

auto const_1_vec = v0::Constant::create(element::i32, Shape{1}, {value});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value is Node, you are trying to create a constant from it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will fix

@muhd360
Copy link
Author

muhd360 commented Sep 20, 2024

@mvafin hi pls check now

@mvafin
Copy link
Contributor

mvafin commented Sep 24, 2024

@muhd360 Tests fail with:

E       Exception happened during conversion of operation aten::index_fill_ with schema aten::index_fill_.int_Tensor(Tensor(a!) self, int dim, Tensor index, Tensor value) -> Tensor(a!)
E       Check 'backward_compatible_check || in_out_elements_equal' failed at src/core/shape_inference/include/reshape_shape_inference.hpp:352:
E       While validating node 'opset1::Reshape Reshape_7527163 (opset1::Mod aten::index_fill_/Mod[0]:i64[], opset1::Constant Constant_7527154[0]:i32[1]) -> (dynamic[...])' with friendly_name 'Reshape_7527163':
E       Shape inference input shapes {[],[1]}
E       Requested output shape [0] is incompatible with input shape

@muhd360
Copy link
Author

muhd360 commented Sep 25, 2024

ok working on it

@muhd360
Copy link
Author

muhd360 commented Sep 27, 2024

@mvafin im getting this error now and i cant seem to figure out the solution
Screenshot from 2024-09-27 09-40-06

@mvafin
Copy link
Contributor

mvafin commented Sep 27, 2024

@muhd360 This error is printed if you do not have implementation of the conversion for this operation. Do you have a release version of openvino in your enviroment?

@muhd360
Copy link
Author

muhd360 commented Sep 27, 2024

but i did add the converter right?yes i have openvino installed on the system

@mvafin
Copy link
Contributor

mvafin commented Sep 27, 2024

but i did add the converter right?yes i have openvino installed on the system

You need to build openvino with your changes, do not use release version.

@muhd360
Copy link
Author

muhd360 commented Sep 27, 2024

how can i do this?

@mvafin
Copy link
Contributor

mvafin commented Sep 27, 2024

@muhd360
Copy link
Author

muhd360 commented Sep 27, 2024

thanks a ton

@muhd360
Copy link
Author

muhd360 commented Oct 8, 2024

hi @mvafin pls assign this issue to someone else im struggling with the build from very long.Sorry to waste your time

@muhd360 muhd360 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support aten::index_fill_ for pytorch models
4 participants