Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE] Remove ConstantFolding pass from normalize #26421

Merged
merged 21 commits into from
Sep 27, 2024
Merged

[PT FE] Remove ConstantFolding pass from normalize #26421

merged 21 commits into from
Sep 27, 2024

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Sep 4, 2024

Details:

  • Remove ConstantFolding pass from normalize
  • Move MarkCompressedFloatConstants from frontends to MOC

Tickets:

@mvafin mvafin requested a review from eaidova September 4, 2024 09:01
@mvafin mvafin requested review from a team as code owners September 4, 2024 09:01
@mvafin mvafin requested review from slyalin and itikhono and removed request for a team September 4, 2024 09:01
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations category: TF FE OpenVINO TensorFlow FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Sep 4, 2024
rkazants
rkazants requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@rkazants rkazants left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read_model "for TF models on disk" scenario can suffer from this change

@mvafin mvafin requested review from a team as code owners September 4, 2024 10:20
@github-actions github-actions bot removed category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Sep 4, 2024
@mvafin mvafin force-pushed the mvafin/pt_fe/cf_remove branch from 02a0e87 to 944343e Compare September 5, 2024 12:47
@github-actions github-actions bot removed the category: transformations OpenVINO Runtime library - Transformations label Sep 11, 2024
@mvafin mvafin requested a review from rkazants September 12, 2024 09:41
@mvafin mvafin requested review from praasz and itikhono September 25, 2024 14:03
@mvafin mvafin added this pull request to the merge queue Sep 27, 2024
Merged via the queue into openvinotoolkit:master with commit 3dee83e Sep 27, 2024
152 checks passed
@mvafin mvafin deleted the mvafin/pt_fe/cf_remove branch September 27, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaidova eaidova eaidova approved these changes

@rkazants rkazants rkazants approved these changes

@praasz praasz praasz approved these changes

@slyalin slyalin Awaiting requested review from slyalin slyalin is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@itikhono itikhono Awaiting requested review from itikhono

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: PyTorch FE OpenVINO PyTorch Frontend do_not_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mvafin @itikhono @eaidova @rkazants @praasz @andrei-kochin