Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OVJS] Avoid of usage global variables in tests #26393

Merged
merged 4 commits into from
Sep 4, 2024
Merged

[OVJS] Avoid of usage global variables in tests #26393

merged 4 commits into from
Sep 4, 2024

Conversation

almilosz
Copy link
Contributor

@almilosz almilosz commented Sep 3, 2024

Details:

  • Avoid dependencies between tests and unexpected behaviours
  • Add beforeEach

Tickets:

@almilosz almilosz requested a review from a team as a code owner September 3, 2024 13:20
@github-actions github-actions bot added the category: JS API OpenVino JS API Bindings label Sep 3, 2024
vishniakov-nikolai
vishniakov-nikolai approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor codestyle fixes are welcome)

@vishniakov-nikolai vishniakov-nikolai added this to the 2024.5 milestone Sep 3, 2024
almilosz and others added 2 commits September 4, 2024 00:09
@almilosz almilosz added this pull request to the merge queue Sep 4, 2024
Merged via the queue into openvinotoolkit:master with commit 41394bb Sep 4, 2024
148 checks passed
@almilosz almilosz deleted the almilosz/js-before-each branch September 4, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishniakov-nikolai vishniakov-nikolai vishniakov-nikolai approved these changes

Assignees
No one assigned
Labels
category: JS API OpenVino JS API Bindings
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
2 participants
@almilosz @vishniakov-nikolai