Mark mandatory conformance tests for HW plugins #26015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
added 5 commits
August 14, 2024 15:41
src/tests/functional/plugin/shared/include/base/ov_behavior_test_utils.hpp
Outdated
Show resolved
Hide resolved
...nal/plugin/conformance/test_runner/api_conformance_runner/src/ov_plugin/core_integration.cpp
Outdated
Show resolved
Hide resolved
src/tests/functional/plugin/shared/include/base/ov_behavior_test_utils.hpp
Outdated
Show resolved
Hide resolved
...nal/plugin/conformance/test_runner/api_conformance_runner/src/ov_plugin/core_integration.cpp
Outdated
Show resolved
Hide resolved
src/tests/functional/plugin/shared/include/base/ov_behavior_test_utils.hpp
Outdated
Show resolved
Hide resolved
...nal/plugin/conformance/test_runner/api_conformance_runner/src/ov_plugin/core_integration.cpp
Outdated
Show resolved
Hide resolved
...nal/plugin/conformance/test_runner/api_conformance_runner/src/ov_plugin/core_integration.cpp
Outdated
Show resolved
Hide resolved
src/tests/functional/plugin/shared/include/base/ov_behavior_test_utils.hpp
Outdated
Show resolved
Hide resolved
...ugins/hetero/tests/functional/shared_tests_instances/behavior/ov_plugin/properties_tests.cpp
Outdated
Show resolved
Hide resolved
peterchen-intel
approved these changes
Sep 18, 2024
peterchen-intel
changed the title
added 2 commits
September 24, 2024 16:24
iefode
reviewed
Oct 8, 2024
| OVClassQueryModelTest, | ||
| ::testing::Values(ov::test::utils::target_device)); | ||
| ::testing::Values(ov::test::utils::target_device), | ||
| MARK_MANDATORY_API_FOR_HW_DEVICE(NULL_getTestCaseName)); |
There was a problem hiding this comment.
Could you please explain the technical details of the changes. I why you create NULLTestCaseName for sw plugin... Is there any other approaches? I asked you because it is not so clear...
There was a problem hiding this comment.
The reason is to support 2 types test cases with unify MACRO:
Some API test cases have implemented getTestCaseName()
For example OVHoldersTestOnImportedNetwork::getTestCaseName
Some are not. For example OVGetMetricPropsTest
Another option, define 2 MACROs:
MARK_MANDATORY_API_FOR_HW_DEVICE_0 without parameter.
MARK_MANDATORY_API_FOR_HW_DEVICE_1 with parameter
There was a problem hiding this comment.
Is it possible to rename as WITH_PARAM and WITHOUT_PARAM
In general, LGTM
|
Replaced by #27197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: