[GPU] Fix regression by selection of reference MatMul #25633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geunhwan
approved these changes
Jul 19, 2024
yeonbok
reviewed
Jul 19, 2024
| @@ -509,6 +514,7 @@ JitConstants FullyConnected_bf_tiled::GetJitConstants(const fully_connected_para | |||
| jit.AddConstant(MakeJitConstant("DYNAMIC_QUANTIZE", 0)); | |||
| } | |||
|
|
|||
| jit.AddConstant(MakeJitConstant("IFM_SIZE", get_input_bf_size(params).second)); | |||
There was a problem hiding this comment.
Can't we just use FILTER_IFM_NUM?
yeonbok
reviewed
Jul 19, 2024
| } | ||
|
|
||
| // In Some model, input_f could be dynamic in input0. It refers to IFM value of weight. | ||
| if (input.is_dynamic() && input_f == 0 && params.weights.IFM().v != 0) | ||
| input_f = params.weights.IFM().v; |
There was a problem hiding this comment.
Can't we always use this as input_f?
Seems that now regardless input0 is dynamic or not, it can just use weight IFM.
+ Resolve unexpected input of dynamic shape from Reshape Signed-off-by: Min, Byung-il <[email protected]>
+ Modified initial input_size Signed-off-by: Min, Byung-il <[email protected]>
Signed-off-by: Min, Byung-il <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: