-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs][PyOV] Documentation for Custom Python Operation #25615
Merged
akuporos
merged 34 commits into
openvinotoolkit:master
from
akuporos:akup/custom-op-docs
Feb 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
205044d
[Docs][PyOV] Documentation for Custom Python Operation
akuporos 13c0a10
make the snippet work
akuporos 5b7f90e
update dpc
akuporos e0f40f9
try to fix doc build
akuporos 8a417a6
Merge branch 'master' into akup/custom-op-docs
akuporos 95ba862
change a little bit
akuporos 091af42
Update docs/articles_en/documentation/openvino-extensibility/custom-o…
akuporos 3cb000a
more changes
akuporos 9939776
Update docs/articles_en/documentation/openvino-extensibility.rst
akuporos f0c3733
Merge branch 'master' into akup/custom-op-docs
mlukasze 4e20847
Merge branch 'master' into akup/custom-op-docs
akuporos a237a03
Update docs/articles_en/documentation/openvino-extensibility.rst
akuporos 753562d
Update docs/articles_en/documentation/openvino-extensibility.rst
akuporos 9ba1424
Update docs/articles_en/documentation/openvino-extensibility.rst
akuporos d25ac84
Update docs/articles_en/documentation/openvino-extensibility/custom-o…
akuporos 1c4732f
apply comment
akuporos 110fd42
Merge branch 'master' into akup/custom-op-docs
akuporos c4d1de8
Update docs/articles_en/documentation/openvino-extensibility/custom-o…
kblaszczak-intel 815bba4
Merge branch 'master' into akup/custom-op-docs
akuporos 32d9076
Merge branch 'master' into akup/custom-op-docs
akuporos 0d0543f
Merge branch 'master' into akup/custom-op-docs
akuporos b505644
Merge branch 'master' into akup/custom-op-docs
kblaszczak-intel 77040b4
Merge branch 'master' into akup/custom-op-docs
akuporos ec254d7
some updates
akuporos 27673d0
Merge branch 'master' into akup/custom-op-docs
mlukasze c3ceabc
update custom-op-doc
akuporos f051ce1
update extensions
akuporos 7ca4439
apply comments
akuporos bc26774
Merge branch 'master' into akup/custom-op-docs
akuporos 240c23f
small update
akuporos 7ecd86d
Update docs/articles_en/documentation/openvino-extensibility/custom-o…
akuporos 4b76a4c
Apply suggestions from code review
sgolebiewski-intel 3c33e61
Apply suggestions from code review
sgolebiewski-intel 1aaeca4
Apply suggestions from code review
sgolebiewski-intel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update docs/articles_en/documentation/openvino-extensibility.rst
- Loading branch information
commit 9ba1424f0bf2557bc86a6e219452fc05c947062a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,7 +124,7 @@ The ``Identity`` is a custom operation class defined in :doc:`Custom Operation G | |
:language: cpp | ||
:fragment: [add_frontend_extension] | ||
|
||
The Python API now supports implementation of custom OpenVINO operations, enabling direct integration within Python code. Even if a custom OpenVINO operation is implemented in C++ and loaded into the runtime by a shared library, there is still no way to add a frontend mapping extension that refers to this custom operation. In this case, use the C++ shared library approach to implement both operation semantics and framework mapping. | ||
The Python API now supports implementation of custom OpenVINO operations, enabling direct integration within Python code. Still python custom operations won't be loaded into the runtime, so use the C++ shared library approach to implement both operation semantics and framework mapping that refers to this custom operation. | ||
|
||
Python can still be used to map and decompose operations when operations from the standard OpenVINO operation set and custom operation implemented in Python are used. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But only via There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes |
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not release notes, I suppose. So
now
is redundant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of the whole sentence doesn't look correct: "Still python custom operations won't be loaded into the runtime, so use the C++ shared library approach to implement both operation semantics and framework mapping that refers to this custom operation.". By definition of Python custom operation you already have "loaded" it in runtime - just insert it into the graph and it will work. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it really makes no sense anymore. Deleted.