[GNA] Fix for concat layer with >2 inputs #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsochack
force-pushed
the
git_fix_concat_with_many_inputs
branch
from
56bf776 to
c6caa83
Compare
bsochack
force-pushed
the
git_fix_concat_with_many_inputs
branch
from
1f71cb8 to
f11a782
Compare
esmirno
suggested changes
Sep 2, 2020
bsochack
changed the title
bsochack
commented
Sep 3, 2020
esmirno
reviewed
Sep 4, 2020
bsochack
force-pushed
the
git_fix_concat_with_many_inputs
branch
from
a2cae5d to
7606031
Compare
dorloff
reviewed
Sep 7, 2020
...ine/tests/functional/plugin/gna/shared_tests_instances/subgraph_tests/concat_multi_input.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/include/subgraph_tests/concat_multi_input.hpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/subgraph_tests/concat_multi_input.cpp
Outdated
Show resolved
Hide resolved
esmirno
reviewed
Sep 7, 2020
...ine/tests/functional/plugin/gna/shared_tests_instances/subgraph_tests/concat_multi_input.cpp
Show resolved
Hide resolved
esmirno
approved these changes
Sep 7, 2020
bsochack
force-pushed
the
git_fix_concat_with_many_inputs
branch
from
fe138aa to
586fe26
Compare
bsochack
changed the title
bsochack
force-pushed
the
git_fix_concat_with_many_inputs
branch
from
6f67fba to
27440dc
Compare
kmagiers
reviewed
Sep 9, 2020
Signed-off-by: Bartosz Sochacki <[email protected]>
Signed-off-by: Bartosz Sochacki <[email protected]>
Signed-off-by: Bartosz Sochacki <[email protected]>
…with auto parameters
bsochack
force-pushed
the
git_fix_concat_with_many_inputs
branch
from
f22277e to
d2676ca
Compare
tadamowicz
pushed a commit
to tadamowicz/openvino
that referenced
this pull request
Aug 30, 2023
* Fix for concat layer with more than 2 inputs Signed-off-by: Bartosz Sochacki <[email protected]> * Fixed check if affine is used for crop layer Signed-off-by: Bartosz Sochacki <[email protected]> * code cleanup for fix affine layer check Signed-off-by: Bartosz Sochacki <[email protected]> * added test for concat layer with multiple inputs * simplified test to use less number of layers * fixed code style * fixed coding style * addressed review comments and one more issue that appeared during testing * fixed code style errors * scale factor propagation for concat layer with multiple inputs * fix for a case when all inputs to concat are activation layers * fix for linux compilation - C++14 is not enabled and fails on lambda with auto parameters * corrected current year in headers in concat multi input tests * fixes for code review issues raised by Denis Orlov * enabled integer mode computation in GNA concat multi input test * removed 1 space per review comment * a fix to fail when not all scale factors are equal * added GNA_DEVICE_MODE config to concat multi input test * corrected searching for a next input to concat layer * changed selection of 2nd candidate for source quant value * code style fix - else and brackets should be in the same line * small code improvement * fix for mixing line endings * addressed with endless requantization loop and fixed failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartosz Sochacki [email protected]