Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Support aten::dot for pytorch models #22074

Closed
mvafin opened this issue Jan 10, 2024 · 18 comments · Fixed by #22978
Closed

[Good First Issue]: Support aten::dot for pytorch models #22074

mvafin opened this issue Jan 10, 2024 · 18 comments · Fixed by #22978
Assignees
@LucaTamSapienza
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Milestone
2024.1

Comments

@mvafin
Copy link
Contributor

mvafin commented Jan 10, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD
@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Jan 10, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Jan 10, 2024
@Sukhvansh2004
Copy link

Can I work on this issue?

@mvafin
Copy link
Contributor Author

mvafin commented Jan 10, 2024

Yes, please do

@mvafin mvafin moved this from Contributors Needed to Assigned in Good first issues Jan 10, 2024
@rkazants
Copy link
Member

Fyi, please use new link to join Intel DevHub Discord server, if you have not yet joined. The previous one is outdated.

Best regards,
Roman

@Sukhvansh2004
Copy link

Yes, sir I have joined the Intel DevHub Discord Server. Thanks for the info though

@Sukhvansh2004 Sukhvansh2004 mentioned this issue Jan 14, 2024
Closed
@Sukhvansh2004
Copy link

apologies on tagging the wrong PR with this issue will update the corrected PR soon

@Sukhvansh2004
Copy link

I am really sorry, as due to some issues I lost my changes of the PR I was about to create and I am not able to find time to redo it. Till the time someone else maybe can take up the issue.

@Sukhvansh2004 Sukhvansh2004 removed their assignment Jan 23, 2024
@mvafin mvafin moved this from Assigned to Contributors Needed in Good first issues Jan 23, 2024
@mvafin
Copy link
Contributor Author

mvafin commented Jan 23, 2024

I am really sorry, as due to some issues I lost my changes of the PR I was about to create and I am not able to find time to redo it. Till the time someone else maybe can take up the issue.

No worries, thank you for notification.

@AlexFierro9
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@AlexFierro9
Copy link

I would like to take a swing at this !!@mvafin

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Jan 24, 2024
@AlexFierro9
Copy link

Unfortunately I haven't been able to get the code running due to compiler issues, so I will be leaving this issue for now, will come back to it if I'm able to resolve that.

Thanks

@AlexFierro9 AlexFierro9 removed their assignment Jan 25, 2024
@mvafin mvafin moved this from Assigned to Contributors Needed in Good first issues Jan 26, 2024
@Om-Doiphode
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues Jan 28, 2024
@andrei-kochin andrei-kochin moved this from Assigned to Contributors Needed in Good first issues Feb 19, 2024
@andrei-kochin
Copy link
Contributor

Moving back to unassigned due to 3 weeks of no activity

@LucaTamSapienza
Copy link
Contributor

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Feb 19, 2024
@andrei-kochin
Copy link
Contributor

andrei-kochin commented Feb 19, 2024 •
edited
Loading

@LucaTamSapienza please focus on the finishing this one #22642 as well as it is still not completed

@LucaTamSapienza
Copy link
Contributor

LucaTamSapienza commented Feb 19, 2024 •
edited
Loading

@andrei-kochin
Ok, I'll continue working on the other task. It seems finished to me; I only have a precision issue with float 16, 32, 64 that I can't resolve. If you have any advice, I'm ready to listen. I apologize again; I didn't mean to create problems.

@LucaTamSapienza LucaTamSapienza mentioned this issue Feb 21, 2024
Merged
@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Feb 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 8, 2024
@LucaTamSapienza @mvafin
[PT FE] aten::dot operation (#22978)
c83c06c 
### Details:
- added `aten::dot` operation for pytorch models

### Tickets:
 - Closes #22074

---------

Co-authored-by: Maxim Vafin <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Mar 8, 2024
@mlukasze mlukasze added this to the 2024.1 milestone Mar 11, 2024
vishniakov-nikolai pushed a commit to vishniakov-nikolai/openvino that referenced this issue Mar 13, 2024
@LucaTamSapienza @mvafin @vishniakov-nikolai
[PT FE] aten::dot operation (openvinotoolkit#22978)
f5bfe84 
### Details:
- added `aten::dot` operation for pytorch models

### Tickets:
 - Closes openvinotoolkit#22074

---------

Co-authored-by: Maxim Vafin <[email protected]>
alvoron pushed a commit to alvoron/openvino that referenced this issue Apr 29, 2024
@LucaTamSapienza @mvafin @alvoron
[PT FE] aten::dot operation (openvinotoolkit#22978)
6533885 
### Details:
- added `aten::dot` operation for pytorch models

### Tickets:
 - Closes openvinotoolkit#22074

---------

Co-authored-by: Maxim Vafin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucaTamSapienza LucaTamSapienza

Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Archived in project
Milestone
2024.1
Development

Successfully merging a pull request may close this issue.

[PT FE] aten::dot operation LucaTamSapienza/openvino
8 participants
@mvafin @rkazants @mlukasze @andrei-kochin @Om-Doiphode @AlexFierro9 @Sukhvansh2004 @LucaTamSapienza