[Good First Issue]: Support aten::expm1 for pytorch models

[mvafin]

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

• Implement conversion rule and/or transformation to support the new operation.
• Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

• torch.expm1 description
• Contribution guide - start here!
• What is OpenVINO?
• OpenVINO PyTorch Frontend
• Blog post on contributing to OpenVINO
• User documentation

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

[Mac16661]

@ilya-lavrenov and @mvafin I would like to work on it.

[Mac16661]

Hi, do u guys have any official discord channel or something ?

[mlukasze]

Hi, do u guys have any official discord channel or something ?

not yet, sorry

[p-wysocki]

Hi @Mac16661, do you need any help?

[Mac16661]

Actuall yes, Im having some trouble setting up this project in my PC

[p-wysocki]

Could you please share what the issues are?

[Mac16661]

@p-wysocki I fixed that issue thanks to stack overflow. Just tell me one thing do I also need to write Unit test for this function?

[p-wysocki]

That's great! Yes, tests are required - you can see how they can be added in the example PR: https://github.com/openvinotoolkit/openvino/pull/18998/files#diff-95d21d5f44f53bb598a50b564360938a47c9495c4ba2cccd65533f1d33b9086e

[Mac16661]

Could you provide the ID of any of your social media accounts if you don't mind, so I can clear my doubts? I have a lot of small ones. Like discord or something .

[Mac16661]

@p-wysocki do u have any command for running these testcases ? Like Im trying to run \openVINO\openvino\tests\layer_tests\pytorch_tests\test_pow.py

[p-wysocki]

Hello @Mac16661!

Could you provide the ID of any of your social media accounts if you don't mind, so I can clear my doubts? I have a lot of small ones. Like discord or something .

We currently do not have any social media for contributors, but that may (I hope) change soon. In the meantime, please ask your questions here, no matter how small they are. :)

@p-wysocki do u have any command for running these testcases ? Like Im trying to run \openVINO\openvino\tests\layer_tests\pytorch_tests\test_pow.py

You can start with the PyTorch Layer Test guide - let us know if you have questions which are not covered by it!

[Mac16661]

@p-wysocki I have some like, I am implementing expm1 method. So I need to get an input vector and then find it's exponential by calling Exp () and then create an vector of same size as input vector contains 1 and then call Subtract ()
passing input vector and new vector filled with 1 as params.

OutputVector translate_expm1(const NodeContext& context, bool out=false) {
    //Getting input vector
    auto vec = context.get_input(0);

    auto exp = context.mark_node(std::make_shared<ov::op::v0::Exp>(vec)); //calculating exp

    return {context.mark_node(std::make_shared<ov::op::v0::Exp>(vec))}; 
     
}

This is how I am trying to implement this function but I don't know how to create a vector? or what this context.mark_node doing?

So do u have any docs which can help me ?

[mlukasze]

@mmikolajcz could you please take a look?

[mvafin]

@Mac16661 You can see on this line how subtract 1 is done in reference PR.
You need to create a Constant with value 1 and call Subtract operation.
More documentation about frontend is available here.
context.mark_node is internal operation that you need to call for each nodes created inside conversion rule, currently it is responsible for assigning names for those nodes, it may be doing more in future.

[p-wysocki]

Hello @Mac16661, do you need any help? Does the provided solution work for you?

Just yesterday our CONTRIBUTING.md has been updated with a technical guide - I highly recommend checking it out. :)

[Mac16661]

I've implemented expm1 method and unit test is also read, but I'm facing some issue in setting up openvino locally. I just need bit more time

[p-wysocki]

Hello @Mac16661, please let us know if there's anything we can help you with. Are you still working on that issue?

I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

[LucaTamSapienza]

Hi, can i work on this issue?

[rghvsh]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[rghvsh]

hey! @LucaTamSapienza would be happy to work together if you want to

[LucaTamSapienza]

@rghvsh sure! i've alredy implemented the expm1.cpp file and also the test for it. Just forgot to do .take to get the issue

[github-actions]

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

[rghvsh]

Ah! that's great let's ask one of the members to co-assign us and I'll get started

[LucaTamSapienza]

@ilya-lavrenov

[LucaTamSapienza]

@rghvsh if you have discord we can talk about it because rn i'm having some issues while i'm running my test

[rghvsh]

sure rzxcs is my username

[p-wysocki]

Hello, is there any help needed?

[LucaTamSapienza]

Actually yes, I'm having a lot of issues due to precision FP::16,32. I've linked my PR above.

[mlukasze]

thank you (again!) @LucaTamSapienza :)