Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MinMax] Embedding nodes as input nodes for inference graph #3320

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Feb 28, 2025

Reopen of the #2862

Changes

  • Embedding nodes are used as input nodes for the inference graph (with that embedding nodes are being included to the inference_nncf_graph)
  • inference_nncf_graph is used to identify weighted nodes
  • PT/FX MinMax get_weight_nodes method is updated to work with the inference graph
  • Constant folding is removed from the OpenVINOQuantizer and FX nncf.quantize implementation

Reason for changes

Related tickets

163025

Tests

  • tests/cross_fw/test_templates/test_quantizer_config.py is updated with shape_of /constant embedding model and conv model with constant branches
  • TorchFX reference graphs for VIT and Swin were updated: constant branches are present in the quantized graph but they don't have quantizers inside
  • conformance test post_training_quantization/625/ - passed

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ experimental labels Feb 28, 2025
@daniil-lyakhov daniil-lyakhov force-pushed the dl/shape_of_sub_emb_fix branch from 9689dca to 0a2f240 Compare February 28, 2025 11:36
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review February 28, 2025 13:28
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner February 28, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant