-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflow in collectors #2337
Merged
AlexanderDokuchaev
merged 3 commits into
openvinotoolkit:develop
from
AlexanderDokuchaev:ad/fix_overflow_in_reducer
Jan 8, 2024
Merged
Fix overflow in collectors #2337
AlexanderDokuchaev
merged 3 commits into
openvinotoolkit:develop
from
AlexanderDokuchaev:ad/fix_overflow_in_reducer
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2337 +/- ##
===========================================
- Coverage 90.88% 85.91% -4.97%
===========================================
Files 492 492
Lines 45115 44674 -441
===========================================
- Hits 41001 38380 -2621
- Misses 4114 6294 +2180
... and 49 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6272c31
to
d857e7f
Compare
daniil-lyakhov
approved these changes
Jan 2, 2024
MaximProshin
added a commit
that referenced
this pull request
Jan 10, 2024
This reverts commit 22b6e58.
AlexanderDokuchaev
pushed a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
NNCF Common
Pull request that updates NNCF Common
NNCF ONNX
Pull requests that updates NNCF ONNX
NNCF OpenVINO
Pull requests that updates NNCF OpenVINO
NNCF PT
Pull requests that updates NNCF PyTorch
NNCF TF
Pull requests that updates NNCF TensorFlow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cast float16 and float32 to float64 for mean and median.
Reason for changes
Error on calculation parameters of FQ for large scale.
Tests
test_reducers_and_aggregators.py::test_overflow