-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move project free commands to outside again #952
Move project free commands to outside again #952
Conversation
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.2.0 #952 +/- ##
==================================================
- Coverage 78.70% 78.70% -0.01%
==================================================
Files 232 231 -1
Lines 26420 26419 -1
Branches 5258 5258
==================================================
- Hits 20795 20794 -1
Misses 4400 4400
Partials 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…move-again-project-free-command-to-outside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
dataset operations
indatum project
are actually project free commands (previously changed in Refactor CLI commands w/ and w/o project #910).datum project
again.Before
datum project
After
datum project
: Remove "dataset operations" groupBefore
datum
After
datum
: Move commands in the "dataset operations" groupHow to test
I corrected the existing tests for this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.