Add ShiftAnalyzer to compute covariate and label shift between two datasets #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 14, 2023 16:12
vinnamkim
reviewed
Mar 14, 2023
vinnamkim
reviewed
Mar 16, 2023
datumaro/plugins/openvino_plugin/samples/ssd_mobilenet_coco_detection_interp.py
Outdated
Show resolved
Hide resolved
datumaro/plugins/openvino_plugin/samples/ssd_person_detection_interp.py
Outdated
Show resolved
Hide resolved
datumaro/plugins/openvino_plugin/samples/ssd_person_vehicle_bike_detection_interp.py
Outdated
Show resolved
Hide resolved
datumaro/plugins/openvino_plugin/samples/ssd_vehicle_detection_interp.py
Outdated
Show resolved
Hide resolved
Comment on lines
+112
to
+135
| if model_name: | ||
| model_dir = os.path.join(os.path.expanduser("~"), ".cache", "datumaro") | ||
| if not osp.exists(model_dir): | ||
| os.makedirs(model_dir) | ||
|
|
||
| # Please visit open-model-zoo repository for OpenVINO public models if you are interested in | ||
| # https://github.com/openvinotoolkit/open_model_zoo/blob/master/models/public/index.md | ||
| url_folder = "https://storage.openvinotoolkit.org/repositories/datumaro/models/" | ||
|
|
||
| description = osp.join(model_dir, model_name + ".xml") | ||
| if not osp.exists(description): | ||
| cached_description_url = osp.join(url_folder, model_name + ".xml") | ||
| log.info('Downloading: "{}" to {}\n'.format(cached_description_url, description)) | ||
| self._download_file(cached_description_url, description) | ||
|
|
||
| weights = osp.join(model_dir, model_name + ".bin") | ||
| if not osp.exists(weights): | ||
| cached_weights_url = osp.join(url_folder, model_name + ".bin") | ||
| log.info('Downloading: "{}" to {}\n'.format(cached_weights_url, weights)) | ||
| self._download_file(cached_weights_url, weights) | ||
|
|
||
| if not interpreter: | ||
| openvino_plugin_samples_dir = get_samples_path() | ||
| interpreter = osp.join(openvino_plugin_samples_dir, model_name + "_interp.py") |
There was a problem hiding this comment.
I think that it is more appropriate to move the model download functionality to _OpenvinoImporter but leave it in this PR.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #855 +/- ##
===========================================
- Coverage 78.59% 78.57% -0.02%
===========================================
Files 201 205 +4
Lines 24534 24726 +192
Branches 4957 4985 +28
===========================================
+ Hits 19282 19428 +146
- Misses 4141 4180 +39
- Partials 1111 1118 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.