Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing tests #803

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 2, 2023

This should be merged after #802.

Summary

  • Split our existing tests into unit, integration/cli, and e2e (empty, TODO)
  • Add some common utils functions to the tests.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim added the infra label Feb 2, 2023
@vinnamkim vinnamkim force-pushed the infra/refactor-tests branch from aff14d0 to 15d4cbc Compare February 2, 2023 11:13
 - Split the existing tests into unit, integration, and e2e/cli

Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim vinnamkim force-pushed the infra/refactor-tests branch from f476150 to 08ae4fa Compare February 3, 2023 00:54
@vinnamkim vinnamkim marked this pull request as ready for review February 3, 2023 01:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 83.95% // Head: 83.93% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (d32c686) compared to base (5daaa9e).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #803      +/-   ##
===========================================
- Coverage    83.95%   83.93%   -0.03%     
===========================================
  Files          174      174              
  Lines        22923    22937      +14     
  Branches      4970     4972       +2     
===========================================
+ Hits         19245    19252       +7     
- Misses        2552     2559       +7     
  Partials      1126     1126              
Flag Coverage Δ
macos-11_Python-3.10 83.84% <75.00%> (-0.03%) ⬇️
macos-11_Python-3.7 83.53% <73.68%> (-0.03%) ⬇️
macos-11_Python-3.8 83.77% <75.00%> (-0.03%) ⬇️
macos-11_Python-3.9 83.78% <75.00%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.10 83.85% <75.00%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.7 83.54% <73.68%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.8 83.78% <75.00%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.9 83.80% <75.00%> (-0.03%) ⬇️
windows-2019_Python-3.10 83.81% <75.00%> (-0.02%) ⬇️
windows-2019_Python-3.7 83.49% <73.68%> (-0.03%) ⬇️
windows-2019_Python-3.8 83.73% <75.00%> (-0.03%) ⬇️
windows-2019_Python-3.9 83.75% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/util/telemetry_utils.py 75.83% <54.54%> (-3.12%) ⬇️
datumaro/util/test_utils.py 89.94% <100.00%> (+0.44%) ⬆️
datumaro/util/telemetry_stub.py 80.00% <0.00%> (-6.67%) ⬇️
datumaro/components/media.py 84.61% <0.00%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim, Vinnam <[email protected]>
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me thank you!

@vinnamkim vinnamkim merged commit 3aa4742 into openvinotoolkit:develop Feb 3, 2023
@vinnamkim vinnamkim deleted the infra/refactor-tests branch February 3, 2023 06:18
@vinnamkim vinnamkim added this to the 1.0.0 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants