-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor existing tests #803
Refactor existing tests #803
Conversation
aff14d0
to
15d4cbc
Compare
- Split the existing tests into unit, integration, and e2e/cli Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
f476150
to
08ae4fa
Compare
Codecov ReportBase: 83.95% // Head: 83.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #803 +/- ##
===========================================
- Coverage 83.95% 83.93% -0.03%
===========================================
Files 174 174
Lines 22923 22937 +14
Branches 4970 4972 +2
===========================================
+ Hits 19245 19252 +7
- Misses 2552 2559 +7
Partials 1126 1126
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Kim, Vinnam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me thank you!
This should be merged after #802.
Summary
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.