Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to the CI and update Ubuntu #1701

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

gdlg
Copy link

@gdlg gdlg commented Jan 23, 2025

Summary

This PR adds support for Python 3.12 in the project configuration and CI. I have left the min Python version unchanged (3.9).

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@gdlg gdlg requested review from a team as code owners January 23, 2025 10:57
@gdlg gdlg requested review from wonjuleee and removed request for a team January 23, 2025 10:57
@gdlg gdlg force-pushed the gppayend/py312 branch 4 times, most recently from 7da95f4 to dccae90 Compare January 23, 2025 21:16
@gdlg gdlg marked this pull request as draft January 23, 2025 21:17
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gdlg gdlg marked this pull request as ready for review January 25, 2025 01:22
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (676bd10) to head (0a76ae9).
Report is 8 commits behind head on releases/1.10.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           releases/1.10.0    #1701   +/-   ##
================================================
  Coverage            81.14%   81.14%           
================================================
  Files                  284      284           
  Lines                32891    32891           
  Branches              5299     5299           
================================================
+ Hits                 26688    26690    +2     
+ Misses                4751     4750    -1     
+ Partials              1452     1451    -1     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 ?
ubuntu-24.04_Python-3.12 81.12% <100.00%> (?)
windows-2022_Python-3.10 ?
windows-2022_Python-3.12 81.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gdlg added 2 commits January 27, 2025 08:57
* Also replace torchtext with tokenizers library.
@gdlg gdlg changed the base branch from develop to releases/1.10.0 January 27, 2025 08:57
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR. I only have some minor comments.

tests/unit/test_framework_converter.py Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat out of scope of this PR, but my concern with this implementation is that it may be unclear to users when to pass just the tokenizer, and when to pass both a tokenizer and a vocab. I think a proper docstring would address this.

Adding the complete dosctring is out of scope, but maybe you could add a brief docstring, or comment, explaining that the vocab arg is not needed when the tokenizer already returns the token ids instead of the raw tokens, and that this depends on which NLP framework is used. Just a brief 1-2 sentence would be sufficient. It's mainly to help whoever adds the full docstring for this class in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done but I think that the construction of those classes needs to be refactored to be simplified. The parameters of the to_framework function depends on which framework is used which makes it difficult to document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I fully agree. We'll address this at a later point.

@djdameln djdameln merged commit 3d0aa04 into openvinotoolkit:releases/1.10.0 Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants