-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop a malformed transform from StackedTransform automatically #1001
Drop a malformed transform from StackedTransform automatically #1001
Conversation
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1001 +/- ##
===========================================
+ Coverage 78.52% 78.53% +0.01%
===========================================
Files 233 233
Lines 26757 26770 +13
Branches 5323 5325 +2
===========================================
+ Hits 21012 21025 +13
Misses 4496 4496
Partials 1249 1249
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me for avoiding an error, but it may require to remove the root cause of an error when stacking transforms. Is there any way to resolve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me for avoiding an error, but it may require to remove the root cause of an error when stacking transforms. Is there any way to resolve this?
Summary
_StackTransform
. Therefore, it would fail if the user tries to apply several transforms to the dataset sequentially and there exist malformed transforms. Also, once a malformed transform is given toDataset.transform()
, that transform permanently remains in the dataset, so creating a new dataset is the only way to solve it.How to test
Unit tests are added for this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.