Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric visualizations #429
Add metric visualizations #429
Changes from 1 commit
bc793aa
cfd92b1
302a728
fe19315
b4bbde7
c0d7f59
6fe5999
cee564f
7b20171
01286f4
f9522a0
629056b
bbbb188
2b6a391
f69b719
0da986f
30b1c17
4c5a795
87b3a2a
469f4ef
e2cf6c2
1dacd8a
43d8e4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure whether it's "bad practice" to call .save on a
AnomalibWandbLogger
multiple times, as is done currently. Any insights?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been a while since I have looked into AnomalibWandbLogger but ideally it should only be called once at the very end. This is explained in the comment above
This is because logging as a single batch ensures that all images appear as part of the same step.
. In case it is being called multiple times then my guess is that theisinstance
falls back to the base class and probably logger ends up always being an instance ofAnomalibWandbLogger
(LightningLogger
more specifically). Maybe a good idea would be to usetype()
but mypy or pylint might complain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted with clearing
AnomalibWandbLogger.image_list
on save. Thus, all predictions are in the first step, and all metrics in the second step (though still under the same namespace)