-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Fix Rich Progress with Patchcore Training #2062
Merged
ashwinvaidya17
merged 1 commit into
openvinotoolkit:feature/pipelines
from
ashwinvaidya17:fix/rich_progress
May 15, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
"""Custom rich methods.""" | ||
|
||
# Copyright (C) 2024 Intel Corporation | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
from collections.abc import Generator, Iterable | ||
from typing import TYPE_CHECKING, Any | ||
|
||
from rich import get_console | ||
from rich.progress import track | ||
|
||
if TYPE_CHECKING: | ||
from rich.live import Live | ||
|
||
|
||
class CacheRichLiveState: | ||
"""Cache the live state of the console. | ||
|
||
Note: This is a bit dangerous as it accesses private attributes of the console. | ||
Use this with caution. | ||
""" | ||
|
||
def __init__(self) -> None: | ||
self.console = get_console() | ||
self.live: "Live" | None = None | ||
|
||
def __enter__(self) -> None: | ||
"""Save the live state of the console.""" | ||
# Need to access private attribute to get the live state | ||
with self.console._lock: # noqa: SLF001 | ||
self.live = self.console._live # noqa: SLF001 | ||
self.console.clear_live() | ||
|
||
def __exit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> None: # noqa: ANN401 | ||
"""Restore the live state of the console.""" | ||
if self.live: | ||
self.console.clear_live() | ||
self.console.set_live(self.live) | ||
|
||
|
||
def safe_track(*args, **kwargs) -> Generator[Iterable, Any, Any]: | ||
"""Wraps ``rich.progress.track`` with a context manager to cache the live state. | ||
|
||
For parameters look at ``rich.progress.track``. | ||
""" | ||
with CacheRichLiveState(): | ||
yield from track(*args, **kwargs) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not directly related to the bug but I am now using
RichProgressBar
in the trainer. I don't mind if we drop this as it is not necessary