Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pipelines] πŸ”¨ Intra-stage result passing #2061

Conversation

ashwinvaidya17
Copy link
Collaborator

πŸ“ Description

  • Add result passing between sages

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

ashwinvaidya17 and others added 19 commits April 4, 2024 16:38
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17
Copy link
Collaborator Author

@blaz-r here is my proposal for passing data between stages

@blaz-r
Copy link
Contributor

blaz-r commented May 15, 2024

Yeah, this looks great. I think this would now cover everything that a pipeline should offer.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ashwinvaidya17 ashwinvaidya17 merged commit 3de51a4 into openvinotoolkit:feature/pipelines May 15, 2024
7 checks passed
@ashwinvaidya17 ashwinvaidya17 deleted the design/intra_stage_results branch May 15, 2024 16:27
ashwinvaidya17 added a commit that referenced this pull request May 24, 2024
* πŸš€ Anomalib Pipelines  (#2005)

* Add initial design

Signed-off-by: Ashwin Vaidya <[email protected]>

* Refactor + add to CLI

Signed-off-by: Ashwin Vaidya <[email protected]>

* Support grid search on class path

Signed-off-by: Ashwin Vaidya <[email protected]>

* redirect outputs

Signed-off-by: Ashwin Vaidya <[email protected]>

* design v2

Signed-off-by: Ashwin Vaidya <[email protected]>

* remove commented code

Signed-off-by: Ashwin Vaidya <[email protected]>

* add dummy experiment

Signed-off-by: Ashwin Vaidya <[email protected]>

* add config

Signed-off-by: Ashwin Vaidya <[email protected]>

* Refactor

Signed-off-by: Ashwin Vaidya <[email protected]>

* Add tests

Signed-off-by: Ashwin Vaidya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samet Akcay <[email protected]>

* address pr comments

Signed-off-by: Ashwin Vaidya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samet Akcay <[email protected]>

* refactor

Signed-off-by: Ashwin Vaidya <[email protected]>

* Simplify argparse

Signed-off-by: Ashwin Vaidya <[email protected]>

* modify logger redirect

Signed-off-by: Ashwin Vaidya <[email protected]>

* update docstrings

Signed-off-by: Ashwin Vaidya <[email protected]>

---------

Signed-off-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Samet Akcay <[email protected]>

* 🐞 Fix Rich Progress with Patchcore Training (#2062)

Add safe track

Signed-off-by: Ashwin Vaidya <[email protected]>

* [Pipelines] πŸ”¨ Intra-stage result passing (#2061)

* Add initial design

Signed-off-by: Ashwin Vaidya <[email protected]>

* Refactor + add to CLI

Signed-off-by: Ashwin Vaidya <[email protected]>

* Support grid search on class path

Signed-off-by: Ashwin Vaidya <[email protected]>

* redirect outputs

Signed-off-by: Ashwin Vaidya <[email protected]>

* design v2

Signed-off-by: Ashwin Vaidya <[email protected]>

* remove commented code

Signed-off-by: Ashwin Vaidya <[email protected]>

* add dummy experiment

Signed-off-by: Ashwin Vaidya <[email protected]>

* add config

Signed-off-by: Ashwin Vaidya <[email protected]>

* Refactor

Signed-off-by: Ashwin Vaidya <[email protected]>

* Add tests

Signed-off-by: Ashwin Vaidya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samet Akcay <[email protected]>

* address pr comments

Signed-off-by: Ashwin Vaidya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samet Akcay <[email protected]>

* refactor

Signed-off-by: Ashwin Vaidya <[email protected]>

* Simplify argparse

Signed-off-by: Ashwin Vaidya <[email protected]>

* modify logger redirect

Signed-off-by: Ashwin Vaidya <[email protected]>

* update docstrings

Signed-off-by: Ashwin Vaidya <[email protected]>

* Add proposal

Signed-off-by: Ashwin Vaidya <[email protected]>

---------

Signed-off-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Samet Akcay <[email protected]>

* Update src/anomalib/pipelines/benchmark/job.py

---------

Signed-off-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Samet Akcay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants