Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Refactor Export #2057

Merged
merged 22 commits into from
May 15, 2024
Merged

🔨 Refactor Export #2057

merged 22 commits into from
May 15, 2024

Conversation

ashwinvaidya17
Copy link
Collaborator

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Ashwin Vaidya <[email protected]>
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

Signed-off-by: Ashwin Vaidya <[email protected]>
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.22%. Comparing base (e95dbe8) to head (b283e78).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/anomalib/models/components/base/export_mixin.py 96.20% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2057   +/-   ##
=======================================
  Coverage   81.21%   81.22%           
=======================================
  Files         225      226    +1     
  Lines       10233    10245   +12     
=======================================
+ Hits         8311     8321   +10     
- Misses       1922     1924    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17 ashwinvaidya17 enabled auto-merge (squash) May 15, 2024 07:30
@ashwinvaidya17 ashwinvaidya17 merged commit c36f87e into main May 15, 2024
8 of 9 checks passed
@ashwinvaidya17 ashwinvaidya17 deleted the feature/refactor_export branch May 15, 2024 07:30
@CarlosNacher
Copy link
Contributor

Hi @ashwinvaidya17 @samet-akcay
One question, perhaps is a Pytorch general doubt, when you model.to_onnx (or to_torch for example), the model you are exporting does use the best weights or the last ones? And when in Anomalib we use the export method of the Engine class, what happens? If the last ones, how should we act to export the best weights taking advantage of the Anomalib's methods?

Thank you so much.

@ashwinvaidya17
Copy link
Collaborator Author

@CarlosNacher can you create a discussion for this (https://github.com/openvinotoolkit/anomalib/discussions) so that it does not get lost in the PRs.

@CarlosNacher
Copy link
Contributor

CarlosNacher commented Jun 4, 2024

@ashwinvaidya17 got it, thank you!

Dicussion: #2110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 Move export functionality to base anomaly module
4 participants