Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PRO metric calculation on GPU #1317

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

blaz-r
Copy link
Contributor

@blaz-r blaz-r commented Sep 1, 2023

Description

Fixes PRO metric calculation on GPU by changing type to float, as well as matches shapes so it works with predictions of shape N, H, W.
I also adjusted tests to verify that it does works with relevant shapes and types.

Changes

Describe the changes you made
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Ensure that you followed the following
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas (If applicable)
  • I have made corresponding changes to the documentation (If applicable)
  • I have added tests that prove my fix is effective or that my feature works (If applicable)

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @blaz-r. I only have a single, very minor comment.

Co-authored-by: Samet Akcay <[email protected]>
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@samet-akcay samet-akcay merged commit a2fbc11 into openvinotoolkit:main Sep 5, 2023
@blaz-r blaz-r deleted the pro_metric_fix branch October 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PRO metric calculation fails on GPU
2 participants