-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics[0]: add per-image overlap (pimo) [GSoC 2023 @ OpenVINO] #1247
Merged
samet-akcay
merged 40 commits into
openvinotoolkit:feature/pimo
from
jpcbertoldo:metrics/root
Aug 23, 2023
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
a67b35f
add per-image overlap (pimo)
jpcbertoldo 6376942
modif plot pimo curves
jpcbertoldo d999729
add warning about memory
jpcbertoldo 3df9849
tiny bug
jpcbertoldo 2b16061
add tuto ipynb
jpcbertoldo cacb653
make image classes a return
jpcbertoldo 56b0bcd
fix ipynb
jpcbertoldo 1476a56
add tests for binclf curve
jpcbertoldo 5557db1
add test to binclf
jpcbertoldo 70f9d37
add aupimo tests
jpcbertoldo 0b05edd
ruff
jpcbertoldo 0c7444e
Configure readthedocs via `.readthedocs.yaml` file (#1229)
samet-akcay b844261
Update binclf_curve.py
jpcbertoldo 784767f
🚚 Refactor Benchmarking Script (#1216)
ashwinvaidya17 5a46d03
Update CODEOWNERS
samet-akcay 3ffc3f6
Enable training with only normal images for MVTec (#1241)
djdameln a62cd92
Revert "🚚 Refactor Benchmarking Script" (#1239)
samet-akcay 09ad1d4
Update benchmarking notebook (#1242)
samet-akcay 0b639d4
add per-image overlap (pimo)
jpcbertoldo 543db2b
modif plot pimo curves
jpcbertoldo c8537c7
add warning about memory
jpcbertoldo 0cb153b
tiny bug
jpcbertoldo c076165
add tuto ipynb
jpcbertoldo ba6a5a6
make image classes a return
jpcbertoldo 974d3bb
fix ipynb
jpcbertoldo 1ff1832
add tests for binclf curve
jpcbertoldo 241fb2e
add test to binclf
jpcbertoldo b8c588f
add aupimo tests
jpcbertoldo 77355a7
ruff
jpcbertoldo 4b67ced
Update binclf_curve.py
jpcbertoldo 311a1e5
Merge branch 'jpcbertoldo/gsoc23-segementation-metrics' of github.com…
jpcbertoldo 7b1eb80
refactor from future pr
jpcbertoldo 6516491
Merge branch 'feature/pimo' into metrics/root
samet-akcay 55f84c8
correct tests
jpcbertoldo 596ebad
add test
jpcbertoldo 0327861
fix test
jpcbertoldo b439e15
add plots tests
jpcbertoldo 35a91ef
Merge branch 'feature/pimo' into metrics/root
jpcbertoldo e2a5b91
correct codacy stuff
jpcbertoldo 3d995e0
correct codacy stuff
jpcbertoldo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# temporary file to manage branches/PRs so they are simpler | ||
|
||
fpr.py | ||
|
||
|
||
tpr.py | ||
|
||
|
||
|
||
|
||
|
||
slogroc.py | ||
|
||
|
||
tpatfp.py | ||
|
||
|
||
|
||
fp_requirement.py | ||
|
||
|
||
|
||
precisionroc.py | ||
|
||
|
||
|
||
scratch.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
"""Per-Image Metrics. | ||
|
||
Overall approach: | ||
Thresholds are computed across all images, but the metrics are computed per-image. | ||
Metrics here are based on binary classification metrics (e.g. FPR, TPR, Precision) over a range of thresholds. | ||
""" | ||
|
||
from .binclf_curve import PerImageBinClfCurve | ||
from .pimo import AUPImO, PImO | ||
|
||
__all__ = [ | ||
"PerImageBinClfCurve", | ||
"PImO", | ||
"AUPImO", | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be
per_img
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to name
PerImageBinClfCurve
something more explicit. BinClf may not be obvious initially. Do you think ifPerImageBinaryClassificationCurve
would be too verbose?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
PerImageBinaryClassificationCurve
at first but it feels very wordy and some lines will become tough to read.binclf
is what I found in torchmetrics so i copied them.per_img
i think it's ok; put it in the list of refactors.