-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fastflow ONNX export. #1108
Fix Fastflow ONNX export. #1108
Conversation
Looks good. From what I tested it works ok, but at some point there is some difference on 7th decimal which probably won't cause problems. According to this pytorch/pytorch#89107 "same" will be supported in PyTorch 2.1, but in the meantime this workaround look great. |
Looks like PyTorch v2.1 will be released some time in october. Meanwhile, we could use this approach to tackle this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonvanzelm, thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, just noticed a minor issue here
Co-authored-by: Samet Akcay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.
Fixes [Bug]: Export to ONNX: UnsupportedOperatorError #1096
Changes
Checklist