-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding package causes an exception TypeError when an resolve is error occurs #319
Comments
Thanks for letting us now. I'll look into this now. |
This problem is because of a bad declaration file for an external module. The resulting js file did not correctly import the |
The declaration files for `npm-registry-fetch` package do not expose the error-class it throws when a fetch failed. Because of this, we wrote our own declaration file for it. The declaration file was incorrectly written. It placed the error class into the packages `index` file even though it is inside `lib/errors`. After updating the declaration and relevant imports the error is now fixed. See #319.
The declaration files for `npm-registry-fetch` package do not expose the error-class it throws when a fetch failed. Because of this, we wrote our own declaration file for it. The declaration file was incorrectly written. It placed the error class into the packages `index` file even though it is inside `lib/errors`. After updating the declaration and relevant imports the error is now fixed. See #319.
Should be fixed in Note that your package can still not be added because of some dependency-issue. The CLI output for this is not great, definitely something to improve. |
@ComradeVanti thanks for this fix! |
Running
openupm add com.annulusgames.lit-motion
results in exceptions in the CLI.Exception:
The
-f
option does not help to avoid this errorManually adding a package does not cause problems.
Dependencies of this package:
The text was updated successfully, but these errors were encountered: