UCP: added the UCX_TLS env parameter for allowing the user to select the uct/s he wants to use. #104
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
@yosefe please review |
| /** | ||
| * Transports, sorted by priority (highest to lowest) | ||
| */ | ||
| typedef enum ucx_uct_id { |
There was a problem hiding this comment.
i don't think we want to have hard-coded list of transports anywhere, it makes the infrastructure less generic.
we can just let the user pass an array of strings (same as with device names) and compare them.
There was a problem hiding this comment.
but this list of tls is limited. wouldn't it be better to hold a predefined list of supported tls?
why is this less generic? i think it's more organized this way
There was a problem hiding this comment.
this way, in order to add new transport, need to add it to this list, instead of just adding a plug-in component.
we wanted it to be more similar to mca (and maybe have transports in separate libraries in the future).
There was a problem hiding this comment.
i dont see why it's wrong to add this to the list. after all, ucp should be aware of the ucts it supports.
but ok, i will change this.
There was a problem hiding this comment.
UCP will be aware of the UCT's, but only during run-time and not in compile-time.
It uses query_resources to get all TLs and their properties.
|
and general comment - looks like commit line is too long. if it's too long, git cuts it off when displaying short log/reflog. |
|
Refer to this link for build results (access rights to CI server needed): |
| /** | ||
| * TL specification | ||
| */ | ||
| typedef struct ucp_tl_config { |
There was a problem hiding this comment.
not critical, but this does not have to be separate struct, can be declared directly inside struct ucp_iface_config
It allows the user to select the uct/s he wants to use.
|
Refer to this link for build results (access rights to CI server needed): |
|
@yosefe please review |
|
👍 |
UCP: added the UCX_TLS env parameter for allowing the user to select the uct/s he wants to use.
UCT/IB: get roce ndev name according to right gid but not fixed gid 0
log basic resource init/fin and transfer functions
No description provided.