Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send Pelias query sources by default #99

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Conversation

evansiroky
Copy link
Contributor

Refactors the geocoder a bit in order to make sure Pelias queries don't send the sources parameter unless explicitly defined in either the config or individual query.

Fixes ibi-group/trimet-mod-otp#239

@landonreed
Copy link
Member

@evansiroky, I think you need to update a snapshot.

Copy link
Member

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs an updated snapshot.

@evansiroky
Copy link
Contributor Author

Oops

@evansiroky evansiroky merged commit 5b4294d into dev Aug 14, 2019
@evansiroky evansiroky deleted the pelias-sources-fix branch August 14, 2019 21:38
@evansiroky evansiroky mentioned this pull request Aug 14, 2019
@evansiroky
Copy link
Contributor Author

🎉 This PR is included in version 0.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pelias forms and the dreaded 'sources' parameter -- part 2
2 participants