Remove star, fix tz issue, and fix index.html #89
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #89 +/- ##
========================================
- Coverage 6.36% 6.36% -0.01%
========================================
Files 134 134
Lines 5997 6001 +4
Branches 1750 1753 +3
========================================
Hits 382 382
- Misses 4747 4750 +3
- Partials 868 869 +1
Continue to review full report at Codecov.
|
| <Icon type={this._isFavorite() ? 'star' : 'star-o'} /> | ||
| </Button> | ||
| {showUserSettings | ||
| ? <Button |
There was a problem hiding this comment.
You can just do showUserSettings && <Button... instead of using a ternary.
There was a problem hiding this comment.
Yea, I'm aware -- I was just kind of feeling the ternary here. Does this stand out as a major style concern to you? I use both, but I did like something I read recently that called out using ternaries in favor of && because it was more readable. Also, this: airbnb/javascript#520 (comment)
The [
condition && <Button...] example looks cleanest, but it suffers from a footgun: if condition is zero, it will be toString'ed and rendered.
There was a problem hiding this comment.
Ah, that reminds me of https://stackoverflow.com/a/43375944/269834. Maybe if we care a lot about this, we can add a linting rule or something.
|
🎉 This PR is included in version 0.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
A couple of fixes:
index.htmlabout which js to use