Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve View Details Link Accessibility #884

Merged
merged 2 commits into from
May 4, 2023
Merged

Improve View Details Link Accessibility #884

merged 2 commits into from
May 4, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

  • Adds role='link' on to ViewDetails button.
  • Adds an invisible a11y label to view details button in stop viewer to further specify which stop each button refers to.
  • Misc formatting in view-stop-button

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks for your work! Just a few nitpicks

lib/components/viewers/view-stop-button.js Outdated Show resolved Hide resolved
lib/components/viewers/view-stop-button.js Outdated Show resolved Hide resolved
AdrianaCeric
AdrianaCeric approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Much more clear

@amy-corson-ibigroup amy-corson-ibigroup merged commit e87b62b into dev May 4, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the view-details-control branch June 27, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@AdrianaCeric AdrianaCeric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @AdrianaCeric @miles-grant-ibigroup