feat: support middleware CDP changes #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
approved these changes
Oct 28, 2021
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
5 tasks
|
Thanks Binh, all changes are addressed. |
miles-grant-ibigroup
assigned binh-dam-ibigroup and miles-grant-ibigroup and unassigned miles-grant-ibigroup, daniel-heppner-ibigroup and binh-dam-ibigroup
|
Deletion prompt updated to match what really happens in 0c64c34 |
|
Also happy to confirm that these changes fix the flex request spray we've been seeing! |
binh-dam-ibigroup
approved these changes
Nov 3, 2021
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a batch ID to all OTP requests and a new confirmation dialog on the terms of storage checkbox.
These changes are done to match the functionality of ibi-group/otp-middleware#152