Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SettingsPreview and TripDetails messages #183

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Add SettingsPreview and TripDetails messages #183

merged 4 commits into from
Jun 29, 2020

Conversation

landonreed
Copy link
Member

@landonreed landonreed commented Jun 29, 2020 •
edited
Loading

Adds new messages pattern for SettingsPreview and TripDetails components.

Non-breaking config changes:

languages:
  settingsPreview:
    label: Trip options
  tripDetails:
    # see TripDetails#defaultProps

evansiroky
evansiroky approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now, but it'd be good for our team to review other approaches to including messages and internationalization/localization stuff so that we have a consistent future-proofed approach to this problem.

binh-dam-ibigroup
binh-dam-ibigroup requested changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least clarify this comment (see https://github.com/opentripplanner/otp-react-redux/pull/183/files#r447208309). I would personally do the suggestion using \n.

@landonreed landonreed merged commit 7525efa into master Jun 29, 2020
@landonreed landonreed deleted the form-fixes branch June 29, 2020 20:10
@landonreed
Copy link
Member Author

🎉 This PR is included in version 0.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@evansiroky evansiroky mentioned this pull request Jul 2, 2020
Merged
@binh-dam-ibigroup binh-dam-ibigroup added the ported-to-otp-ui Indicates whether changes made to the maintenance branch have been ported to otp-ui label Jul 8, 2020
@landonreed
Copy link
Member Author

🎉 This PR is included in version 1.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@landonreed landonreed

Labels
ported-to-otp-ui Indicates whether changes made to the maintenance branch have been ported to otp-ui released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@landonreed @evansiroky @binh-dam-ibigroup