Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove watchPosition in favor of setInterval #1348

Merged
merged 2 commits into from
Feb 11, 2025
Merged

remove watchPosition in favor of setInterval #1348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46eb08b
remove watchPosition in favor of setInterval
amy-corson-ibigroup Feb 4, 2025
2c8af8a
Merge branch 'dev' into remove-watchposition
amy-corson-ibigroup Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 4 additions & 33 deletions lib/components/app/responsive-webapp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,6 @@ class ResponsiveWebapp extends Component {

/** Lifecycle methods **/

// Check if the position has changed enough to update the currentPosition
// (prevent constant updates in nearby view)
// .001 works out to be about 94-300 ft depending on the longitude.
positionShouldUpdate = (position) => {
const { currentPosition } = this.props
if (!currentPosition.coords) return true
const latChanged =
Math.abs(
position?.coords?.latitude - currentPosition?.coords?.latitude
) >= 0.001
const lonChanged =
Math.abs(
position?.coords?.longitude - currentPosition?.coords?.longitude
) >= 0.001

return latChanged || lonChanged
}

/* eslint-disable-next-line complexity */
componentDidUpdate(prevProps) {
const {
Expand Down Expand Up @@ -197,21 +179,10 @@ class ResponsiveWebapp extends Component {
if (isMobile()) {
// Test location availability on load
getCurrentPosition(intl)
// Watch for position changing on mobile
navigator.geolocation.watchPosition(
// On success
(position) => {
if (this.positionShouldUpdate(position)) {
receivedPositionResponse({ position })
}
},
// On error
(error) => {
console.log('error in watchPosition', error)
},
// Options
{ enableHighAccuracy: true }
)
// Update position every 30 seconds. watchPosition interferes with react-map-gl.
setInterval(() => {
getCurrentPosition(intl)
}, 30000)
}
// Handle routing to a specific part of the app (e.g. stop viewer) on page
// load. (This happens prior to routing request in case special routerId is
Expand Down
Loading