Advanced Trip Form #1249
Advanced Trip Form #1249
Conversation
…pplanner/otp-react-redux into advanced-trip-form-panel
| @@ -22,20 +45,28 @@ interface Props { | |||
|
|
|||
| class BatchSearchScreen extends Component<Props> { | |||
| state = { | |||
| planTripClicked: false | |||
| closeAdvancedSettingsWithDelay: false, | |||
| planTripClicked: false, | |||
There was a problem hiding this comment.
Did I get confused with a mockup? I thought the Advanced Trip Form took the entire screen on mobile view. Right now, only a tiny height is available (the height of the origin/destination and mode selector fields), so it is very awkward to use on mobile view. (see screenshot)
There was a problem hiding this comment.
Weird, yes, it should expand to full screen when opened. Where are you seeing this? Just tested this branch on safari, chrome, and firefox on mobile and I can't reproduce this. Is it showing up in a certain context?
There was a problem hiding this comment.
I see that on Firefox devtools, Firefox on Android, Chrome devtools and Chromium on Android.
There was a problem hiding this comment.
I just got this thought after looking at the location selector for the mobile view, any of the following could be done in another PR... It seems like this could be a dialog, at least in the mobile view, what do you think? That way, the Advanced Trip Options panel can be dismissed using the ESC key, and for desktop, the focus would be contained within the dialog.
…planner/otp-react-redux into master-trip-form-update
Description:
Moves mode subsettings into "Advanced" trip panel. Requires opentripplanner/otp-ui#749
PR Checklist: