Route type comparator does not consider GTFS route types in long route response

[landonreed]

OTP has two different response types in the transit index for routes: long and short.

The short response (which the route type comparator in otp-rr) currently handles contains a Route@mode field, which maps to the OTP transit mode enum values (e.g., BUS and RAIL). However, in the long response from OTP, the mode field is dropped in favor of route_type, which uses the int-based route types from GTFS. So, when a route is clicked in the otp-rr route viewer, the route object is replaced with the long response, and it drops the mode field. Originally, I thought the route was just disappearing from the list, but in fact it was dropping to the bottom of the list (in accordance with the route type comparator logic -- default to 9999).

otp-react-redux/lib/util/itinerary.js

Lines 278 to 289 in a16abb4

	case 'FERRY':
	return 5
	case 'CABLE_CAR':
	return 6
	case 'FUNICULAR':
	return 7
	case 'BUS':
	return 8
	default:
	return 9999
	}
	}

[evansiroky]

🎉 This issue has been resolved in version 0.13.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀