3641 complexity score #250
Open
+65
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdhayhurst
commented
Jan 31, 2025
jdhayhurst
commented
- resolves Include page size and query depth in the complexity calculation issues#3641
- add complexity score calculations for nested objects
javfg
previously approved these changes
Feb 7, 2025
remo87
reviewed
Feb 7, 2025
| case object TooComplexQueryError extends Exception("Query is too expensive.") with Logging { | ||
| case object TooComplexQueryError | ||
| extends Exception( | ||
| "Query is too expensive. The response size is likely to be too large. Try requesting smaller page sizes" |
There was a problem hiding this comment.
I'm not too sure about this bit Try requesting smaller page sizes because it would suggest that the queries have pagination and reducing the size could solve the issue and that's not always the case
There was a problem hiding this comment.
Thanks, that's true in some cases. How about this?
"Query is too expensive. The response size is likely to be too large. Try requesting smaller page sizes or fewer items"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.