-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update poetry to version 2 #969
Conversation
This PR is blocked because the deptry tests are failing. This tool checks that we don't use any dependency in the code that is not defined in the TOML. Tests should pass once deptry is updated. |
license = "Apache-2.0" | ||
readme = "README.md" | ||
documentation = "https://opentargets.github.io/gentropy/" | ||
repository = "https://github.com/opentargets/gentropy" | ||
packages = [{ include = "gentropy", from = "src" }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packages
and requres-poetry
are not available at the project
, by the looks of the documentation https://python-poetry.org/docs/pyproject/#packages and https://python-poetry.org/docs/pyproject/#requires-poetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the structure in https://github.com/python-poetry/poetry/blob/main/pyproject.toml
I guess both ways are correct
✨ Context
Poetry 2.0 has been released with breaking changes that caused our tests to fail because the TOML wasn't following the new structure.
Changes are described here: https://python-poetry.org/blog/announcing-poetry-2.0.0
I've migrated the config to the new structure, interestingly you can now pin the Poetry version to use.
🛠 What does this PR implement
typing
's modules🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?