Also load TTC font files #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been deployed, renderd restarted but a force re-render has not been started. @zerebubuth can update. |
|
It's worth merging this in and making a new release. My package includes this as a "back port" patch, but it would be better to have a new version number. I don't know how to test this - presumably force-rerender a tile containing a something with a name in a script which falls back to Noto? Anyone know of any examples? |
|
Thanks! For example, you could rerender 17/111771/50757.png, which currently looks like |
|
That was rendered a moment ago. The Korean text definitely looks different, so hopefully that means the new fonts are enabled and it looks better? |
|
I can confirm that Noto Sans CJK is enabled, the new font is much better in Taiwan. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141 .
As discussed in gravitystorm/openstreetmap-carto#2391 and gravitystorm/openstreetmap-carto#2397 , the Noto CJK fonts that the openstreetmap-carto style uses are currently not used on the rendering servers. They have the extension ".ttc" and are supported by Mapnik.
I have not tested this pull request, but I assume it will solve the problem.