Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental mismatch of "PAMAP" #8889

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Conversation

cicku
Copy link
Contributor

@cicku cicku commented Jan 9, 2022

image

@mmd-osm
Copy link
Contributor

mmd-osm commented Jan 9, 2022

https://www.openstreetmap.org/way/166528135 would no longer be flagged by this change, although it might be still incompatible data (edit: to be verified!).

Adding more tests in https://github.com/openstreetmap/iD/blob/develop/test/spec/validations/incompatible_source.js might be good.

@cicku
Copy link
Contributor Author

cicku commented Jan 10, 2022

I don’t know anything about Europe so I can’t help here. As far as I can see it’s a regression introduced by a patch to warn about proprietary Chinese data.

@tyrasd tyrasd added bug A bug - let's fix this! validation An issue with the validation or Q/A code labels Jan 28, 2022
@tyrasd tyrasd merged commit eb82698 into openstreetmap:develop Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants