Improve the checking of results from the NSI matcher.. #8828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fixes: osmlab/name-suggestion-index#5693) Previously the code would accept the first useful match, however this match might be an "alternate" match. Now we keep iterating until we find a "primary" match. This bug could cause the validator to suggest upgrading well-tagged features to a less wanted feature type. For example a "Tesla Supercharger" would flip to a "Tesla Destination Charger" if it had "Tesla" anywhere in its list of tags (because `short_name=Tesla` is an "alternate" match for both destination chargers and super chargers)
tyrasd
added
bug
|
whoa thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes: osmlab/name-suggestion-index#5693)
Previously the code would accept the first useful match, however this match
might be an "alternate" match. Now we keep iterating until we find a "primary"
match.
This bug could cause the validator to suggest upgrading well-tagged features to
a less wanted feature type. For example a "Tesla Supercharger" would flip to
a "Tesla Destination Charger" if it had "Tesla" anywhere in its list of tags
(because
short_name=Teslais an "alternate" match for both destinationchargers and super chargers)