Presets for golf paths and cartpaths and driving ranges #5862
Conversation
|
Also added a driving range preset since it's the 10th most common golf tag and has a wiki entry. |
chadrockey
changed the title
| }, | ||
| "reference": { | ||
| "key": "golf", | ||
| "value": "cartpath" |
There was a problem hiding this comment.
I don't see a reference page for golf=cartpath
https://taginfo.openstreetmap.org/tags/golf=cartpath
If you're inventing this tag, please reconsider.
A more normal way of nesting OSM tags might look like:
highway=path+path=golf_cart
or
highway=track+track=golf_cart+tracktype=grade1
| "line" | ||
| ], | ||
| "tags": { | ||
| "golf": "path", |
There was a problem hiding this comment.
same stuff applies here as I said on the cartpath preset above..
It should probably be highway=path + path=golf
|
@bhousel Thanks! Turns out that json linters can't catch : inside of the quotes. :) As far as the tags, I got them from here: Cartpath and Path are 11 and 13th most common. If the tags are accepted here, I'll look into what else is required to standardize the in-use tags and will at minimum complete the wiki entries with suitability licensed example photos. My motivation is that I'm using the rest of the golf: tags for metadata analysis. What I'd like to see is the standard for "natural walking trails", which I understand to be highway: footway (walking only, not wide enough to be a track or intended for vehicles) and highway: path (with golfcart designated as suggested). The idea being that there is a standard tag for rendering and the golf: tags seem to be "extras" across the board. For example, they are mostly landuse: grass, but that grass happens to be a golf:green. With this in mind, I tried to find the most suitable walking paths and small vehicle paths and use add the "extra" golf tags. Specifically, I'm trying to make it clear which paths are part of the design of golfcourses vs merely near a golf course. There may be a hiking trail near a golf course, but a path architected to go from golf green to the following tee box isn't for general use and is a crucial part of the golf course. Please let me know if the taginfo is valid and acceptable proof of use with my understanding of the golf: tags in general. Thank you for reviewing. Will I be able to test these changes if I follow through with the npm install? I'd like to see that the icons, descriptions, and nesting are all correct. |
Yes, it's not strictly an error - you can put anything in the quotes.
Sure but a few hundred uses is not really established:
UPDATED: We should not use This looks strange to me:
Yes! |
|
@bhousel Can you comment if the wiki is out of date? Most golf cart paths are not wide enough for tractors or jeeps, so this suggests that "path" should be used. And while "path" suits both the walking and golf cart paths, now there isn't a clear distinction. I would say that walking paths most resemble hiking paths, with maybe nicer grass and less dirt. So the two possibilities I see:
In either case, should "golf_cart": "designated" be included? |
I don't know, sorry. It seems ok. Actually I've been thinking about it more, and this is probably a situation where we should just use The
|
|
@bhousel I updated this in the only way I could find that avoids connectivity errors in my editor. I did try everything out locally and it's exactly what I wanted in terms of the UI and labeling. Very clear and easy to search! Ultimately, our reasoning for these paths is that they are not highways or routing paths - you can't really take them on route from a point A to a point B. They are more descriptive pieces of the map. Even within a golf course, there are often segments and routes that aren't for routing but just for traffic management. For example, there may be no clear path between a tee and a green because you go to where your ball is, not in a consistent path. Routing in this instance is out of scope for Open Street Map, it's not necessary to always navigate from "Hole 15 to Hole 7". For this reasoning, we're proposing to only use golf: cartpath and golf: path in these situations, primarily to avoid connectivity errors. In situations where the routes are NOT intended solely for the game of golf, then the usual highway rules will take precedent. For example, a theme park has "golf cart paths" that its employees and emergency personnel use to travel in areas off limits to the guests. These are NOT golf: cartpaths, but are the usual highway: path or highway:track. This will need to be a clear distinction on the wiki pages. For situations where both situations apply: example: a retirement community built around a golf course where the course's cart paths serve the purpose for the game as well as transportation routes for the residents, then the most appropriate tagging will be highway path/track with the golf:cartpath tag added. Do you think these cases should be handled in the wiki? Or should we add another preset or two here so that these difficult cases are handled better for users? Maybe the set in order of Game -> Transportation: The last open item is that there's obviously no rendering for these. Is there a secondary tag available that will provide clear rendering? If not, I will work with the rendering project to add rendering for these "new" tags. |
|
For what it's worth, I prototyped a first pass at this idea and I think it works well. It preserves the usage of highway:track for the larger, multipurpose golf cart paths, while supporting the game "golf:cartpath" tag. I looked for a quick example and found this area. Here you can see a Golf Cartpath transition into a special portion of the road where residents drive their own golf carts, even when they are not playing the game. After a while, the highway turns back into a Golf Cartpath and is only used/intended when actually playing.
|
Could you use otherwise looks good 👍
No, sorry.. We usually don't consider whether or not a feature will be rendered on the main osm-carto style, because people can make their own renderings if they want to, and the osm-carto project moves kind of slowly (some of this is due to technical limitations of how they render - they need to change their database schema to support new tags sometimes). |
|
@bhousel Service sounds like a good fit! Thanks! OK, all updated. Do I need to remove data/taginfo from the PR? |
Thanks @chadrockey looks good! No need to change the taginfo stuff, I will merge and rebuild everything, and make some updates to the .css files so the paths render nicely 👍 |
|
@quincylvania Do you have a timeline of when this might go live? I'd like to make a video tutorial but don't want to do so until these new features are in. I could record from a local instance of iD, so I might do that. Thanks! |
|
@chadrockey We're aiming for a release later this week! Though it can take another day or so until it's live on openstreetmap.org |
Adds presets to correctly tag golf paths.
golf: cartpath is intended for the small, single vehicle electric or gas powered golf carts on an actual golf course. North American/USA style golf.
golf: path is intended for walking only paths, typically in more traditional golf where walking is more common. Intended for the connecting routes between holes on an actual golf course.
Related issue: #5859
Looking for feedback on correctness and how to validate my changes.