Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Two points are very close" warning: Do not autofix when nodes are member of more than one way and angles are not 180° #7379

Closed
sb12 opened this issue Feb 22, 2020 · 2 comments
Assignees
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Milestone

Comments

@sb12
Copy link

sb12 commented Feb 22, 2020

Hello,
I think there is a problem with the warning "Two points are very close" in regions that are mapped very detailed.
Example:
grafik
If you auto-join these nodes, you will change the geometry of the rectangle building (in some cases you might even end up with a two-node building by applying the autofix several times):
grafik
I think these validator warnings should only be shown, when the angles for all ways sharing the nodes are close to 180°, otherwise there is a great chance that you destroy very detailled but completely valid data (3D buildings, indoor mapping etc.).
The validator warnings suggest that there is something wrong in the data, so there are some OSM users that try to get their area free of warnings and just apply the autofixes without thinking. It is also very difficult to see the actual change in the iD-Editor because you have to zoom in very close.
I just spent 1 hour to fix geometries that were destroyed by this validator warning autofix.

@quincylvania
Copy link
Collaborator

Hello and welcome, @sb12. This does look like a problem… can you post a link to somewhere iD issues these warnings?

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Feb 24, 2020
@sb12
Copy link
Author

sb12 commented Feb 24, 2020

@quincylvania quincylvania self-assigned this Feb 24, 2020
@quincylvania quincylvania added the bug A bug - let's fix this! label Feb 24, 2020
@quincylvania quincylvania added this to the Next Release milestone Feb 24, 2020
zlavergne pushed a commit to KaartGroup/iD that referenced this issue Mar 10, 2020
@quincylvania quincylvania modified the milestones: 3.0.0, 2.18.0 May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

2 participants