Hidden entities remain hidden upon selection

[kymckay]

This is behaviour exposed by the addition of QA errors where entities are linked in the error description.

Example where this can be confusing:
&map=19.20/55.35233/-1.72707
https://giant.gfycat.com/NervousSnoopyCarp.webm

Some sections of road surface area are incorrectly tagged here which ImproveOSM is flagging as missing one-way tags. Since I'm (theoretically) a user just interested in fixing road issues I have all other features disabled. At first glance it looks like these QA errors are just outdated and already fixed because the highways are definitely tagged "oneway". However, enabling the landuse features shows the real error subject was the badly mapped road area.

I see two possible solutions here:

• Force the currently selected (and hovered?) entity to always be visible regardless of enabled features.
• Disable sidebar editing and show a message to inform that the currently selected entity is not visible.

[bhousel]

• Force the currently selected (and hovered?) entity to always be visible regardless of enabled features.

I did something like this.. The user needs to select the error, but then it will force visible any entities related to the error. (I couldn't do it on hover because the hover is a css-only effect and the thing being hovered needs to be drawn already)

[bhousel]

cc @quincylvania - do you need this for anything on the validation branch / #5830 ? (I'll check too)

[quincylvania]

@bhousel Yep, clicking issues issues in the pane selects the features. What do you think of generally showing the selected features no matter where the selection came from? That way we don't have to manually address every instance of feature selection.

[bhousel]

What do you think of generally showing the selected features no matter where the selection came from? That way we don't have to manually address every instance of feature selection.

modeSelectError doesn't actually select the entities, it just selects the error, and the added code whitelists any related entities so that they will definitely be drawn. We put them into a _forceVisible object for performance reasons (it's much faster to lookup entity ids this way than in an array, and isHidden is very hot code).

In 151e268 I added this for the main modeSelect also, so that if normally entities get selected somehow, they should be shown.

I haven't checked this, but I can imagine situations in the code where it can happen, such as a user searches for something hidden and clicks on it from the search results, or they click on hidden relation child in the raw member editor.

[quincylvania]

In 151e268 I added this for the main modeSelect also, so that if normally entities get selected somehow, they should be shown.

@bhousel Thanks! I checked, and this suits the case of selecting features via the issues pane in the validation branch.